Conversation
devsnek
requested review from
bartlomieju
and removed request for
lucacasonato
bartlomieju
reviewed
Nov 29, 2024
Comment on lines
+789
to
+795
| let x = v8::ValueView::new(scope, string); | ||
| match x.data() { | ||
| v8::ValueViewData::OneByte(bytes) => { | ||
| String::from_utf8_lossy(bytes).into_owned() | ||
| } | ||
| v8::ValueViewData::TwoByte(bytes) => String::from_utf16_lossy(bytes), | ||
| } |
Member
There was a problem hiding this comment.
Is there a reason to do it instead of v8::String::to_rust_string_lossy()?
ext/telemetry/lib.rs
Outdated
| spans.on_end(temporary_span.0); | ||
| } | ||
|
|
||
| pub struct TemporaryMetricsExport { |
Member
There was a problem hiding this comment.
Could you add some docstrings here about the purpose of these structs and enums?
Co-Authored-By: Luca Casonato <hello@lcas.dev>
bartlomieju
approved these changes
Dec 2, 2024
bartlomieju
pushed a commit
that referenced
this pull request
Dec 5, 2024
Refs: #26852 Initial support for exporting metrics. Co-authored-by: Luca Casonato <hello@lcas.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #26852
Initial support for exporting metrics.